Acoustics SPL bugfix #379
Merged
Acoustics SPL bugfix #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssolson
reviewed
Feb 13, 2025
mhkit/acoustics/analysis.py
Outdated
Comment on lines
831
to
835
| # Interpolate between band frequencies if width is narrow | ||
| x = spsd["freq"].sel(freq=slice(*band_range)) | ||
| if len(x) < 2: | ||
| spsd_slc = spsd.interp(freq=band_range) | ||
| x = band_range |
There was a problem hiding this comment.
If the dataset is large could this interp lead to performance issues where we would want to warn the user of what was slowing down the code?
There was a problem hiding this comment.
Good question, I'm not sure.
This if statement should only happen at low frequencies, so in the next commit I'll slice the dataset down before interpolating. Should be faster.
| @@ -473,6 +473,44 @@ def _validate_method( | |||
| return method_name, method_arg | |||
|
|
|||
|
|
|||
| def _create_frequency_bands(octave, fmin, fmax): | |||
There was a problem hiding this comment.
Should we add some input checks?
if not isinstance(octave, int) or octave <= 0:
raise TypeError("octave must be a positive integer.")
if not isinstance(fmin, int) or not isinstance(fmax, int):
raise TypeError("fmin and fmax must be integers.")
if fmin <= 0:
raise ValueError("fmin must be a positive integer greater than zero.")
if fmax <= fmin:
raise ValueError("fmax must be greater than fmin.")
There was a problem hiding this comment.
I didn't add these because they're already checked in the respective functions that use this one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug where calculating SPLs in lower frequency bands was failing because the bandwidth resolution was on par with the frequency resolution, i.e. numpy.trapz was failing to calculate the integral because the input was only 1D over frequency. Also expanded testing to cover this particular case.