fix bug in adjust_mass.f90 #768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a subtle bug in the adjust_mass/adjust_J_lost routine.
When the star is hardly losing mass (say
s% star_mdot < -1d-99, which is possible when eg using "Kolb" mass transfer without winds), themass_lostin the routine still reads0d0to floating point precision, ands% adjust_J_qis untouched at0d0Later, in
timestep.f90, the check is whethers% mstar_dot < 0d0, which it is, it's-1d-99, and then any hard limit is always hit, causing infinite retries.this is a simple fix to this bug.