Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add monicayao as a contributor #319

Merged
merged 2 commits into from
Jun 1, 2019
Merged

Conversation

allcontributors[bot]
Copy link
Contributor

Adds @monicayao as a contributor for doc.

This was requested by jbteves in this comment

@jbteves
Copy link
Collaborator

jbteves commented Jun 1, 2019

@emdupre weirdly this didn't cause a merge conflict unlike the previous ones. Maybe the bot's been repaired? I requested your review to make sure the bot created everything correctly. My feeling if this is what you want is that we should close the other PR I opened for @tsalo and then attempt to have the bot run on it a second time; thoughts?

@codecov
Copy link

codecov bot commented Jun 1, 2019

Codecov Report

Merging #319 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #319   +/-   ##
======================================
  Coverage    49.2%   49.2%           
======================================
  Files          39      39           
  Lines        2140    2140           
======================================
  Hits         1053    1053           
  Misses       1087    1087

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac26ebb...912ee59. Read the comment docs.

@emdupre
Copy link
Member

emdupre commented Jun 1, 2019

I think this looks great ! I'm happy to merge this as-is. Whether we should close and then re-open the pull request for Taylor (and you) is something I'm not clear on... will wait to see if Kirstie has feedback in that PR. But if that sounds like an OK plan to you feel free to merge this whenever you're ready !

Copy link
Collaborator

@jbteves jbteves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving per @emdupre's comments

@jbteves jbteves merged commit 6a842b9 into master Jun 1, 2019
@jbteves jbteves deleted the all-contributors/add-monicayao branch June 1, 2019 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants