Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOC] Updates CONTRIBUTING to reflect contribution spec and bot #309

Merged
merged 3 commits into from
Jun 3, 2019
Merged

[DOC] Updates CONTRIBUTING to reflect contribution spec and bot #309

merged 3 commits into from
Jun 3, 2019

Conversation

jbteves
Copy link
Collaborator

@jbteves jbteves commented May 26, 2019 •
edited
Loading

Progress on #259

Changes proposed in this pull request:

  • Adds all-contributors spec and notes bot usage

@jbteves jbteves requested a review from emdupre May 26, 2019 03:29
@jbteves jbteves mentioned this pull request May 26, 2019
Closed
3 tasks
@codecov
Copy link

codecov bot commented May 26, 2019 •
edited
Loading

Codecov Report

Merging #309 into master will decrease coverage by 0.16%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #309      +/-   ##
=========================================
- Coverage   49.36%   49.2%   -0.17%     
=========================================
  Files          39      39              
  Lines        2133    2140       +7     
=========================================
  Hits         1053    1053              
- Misses       1080    1087       +7
Impacted Files Coverage Δ
tedana/selection/tedica.py 23.52% <0%> (-1.28%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84b7c4c...c9caadf. Read the comment docs.

emdupre
emdupre reviewed May 26, 2019
View reviewed changes
emdupre
emdupre reviewed May 26, 2019
View reviewed changes
Copy link
Member

@emdupre emdupre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! I just think we should remove the reference to the contributors tab (since non-code contributions don't show up there) and point folks to the README instead of the contributing doc. Thanks so much !! 🚀

@jbteves @emdupre
Update CONTRIBUTING.md
c9caadf 
Co-Authored-By: Elizabeth DuPre <[email protected]>
@jbteves jbteves closed this May 30, 2019
@jbteves jbteves deleted the JT_add_all-contributors branch May 30, 2019 17:56
@jbteves jbteves restored the JT_add_all-contributors branch May 30, 2019 17:56
@jbteves jbteves reopened this May 30, 2019
@jbteves
Copy link
Collaborator Author

jbteves commented May 30, 2019

Sorry, I was a dummy with tab completion and I accidentally deleted this branch instead of my intended target.

emdupre
emdupre approved these changes Jun 3, 2019
View reviewed changes
Copy link
Member

@emdupre emdupre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨ 🚀

@jbteves jbteves merged commit 95d38fe into ME-ICA:master Jun 3, 2019
@jbteves jbteves deleted the JT_add_all-contributors branch September 13, 2019 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emdupre emdupre emdupre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jbteves @emdupre