Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Back-fill, then forward-fill, NaNs in external regressors #1163

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Jan 7, 2025

Closes #1152.

Changes proposed in this pull request:

  • Warn if the external regressors have NaNs.
  • Back-fill (and forward-fill) cells with NaNs in the external regressors DataFrame.

@tsalo tsalo added the bug issues describing a bug or error found in the project label Jan 7, 2025
@tsalo tsalo requested a review from handwerkerd January 7, 2025 15:20
@tsalo tsalo changed the title Back-fill NaNs in external regressors Back-fill, then forward-fill, NaNs in external regressors Jan 7, 2025
@tsalo
Copy link
Member Author

tsalo commented Jan 7, 2025

Coverage didn't upload. Maybe they're disabled tokenless uploads?

@tsalo tsalo requested a review from eurunuela January 14, 2025 15:44
@eurunuela
Copy link
Collaborator

eurunuela commented Jan 14, 2025

Coverage didn't upload. Maybe they're disabled tokenless uploads?

From looking at the merges in main:

{"message":"Token required - not valid tokenless upload"}

400

@tsalo
Copy link
Member Author

tsalo commented Jan 14, 2025

I just changed the settings on CodeCov so we shouldn't need tokens no matter what. Hopefully that resolves things in the future.

@tsalo tsalo merged commit f84cbbc into ME-ICA:main Jan 14, 2025
14 checks passed
@tsalo tsalo deleted the external-regressors-nans branch January 26, 2025 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug issues describing a bug or error found in the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

External regressors with NaNs will crash decision tree
2 participants