Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dash versions of underscore params #1147

Merged
merged 1 commit into from
Nov 16, 2024
Merged

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Nov 16, 2024

Closes none. This makes the formatting of params consistent.

Changes proposed in this pull request:

  • Add dash versions of --ica-method and --n-robust-runs. I didn't remove the underscore versions, but we should in the next major release.

@tsalo tsalo added the enhancement issues describing possible enhancements to the project label Nov 16, 2024
@tsalo tsalo requested a review from eurunuela November 16, 2024 13:29
Copy link
Collaborator

@eurunuela eurunuela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. LGTM!

@tsalo tsalo merged commit 6438dfa into ME-ICA:main Nov 16, 2024
14 checks passed
@tsalo tsalo deleted the dash-params branch November 16, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement issues describing possible enhancements to the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants