-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename variables #1145
Rename variables #1145
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't see anything that would indicate this but I imagine the column names haven't changed in the tsv files, right?
That would make Rica break and I would have to release an update to look for that.
It should only rename internal variables. I avoided changing column names or command-line parameters. There's always a chance that I missed something though... |
I don't think you did. But I wanted to double-check. Thanks, Taylor! |
I think this PR merits two reviewers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
One very minor thing I noticed ismmix
is always mixing
but ica_reclassify_workflow
has mmix_orig
while other places use mixing_orig
. This is really minor since this is effectively a local temp variable and I don't think this will confuse anyone.
Thanks @eurunuela and @handwerkerd!
I just changed it. Once CI passes I'll merge. |
Related to #919. Tedana development's been pretty quiet lately, so I figured it's a good time to rename the variables we've wanted to rename for a while now.
Changes proposed in this pull request: