Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require only one approving review for minor pull requests #1135

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Require only one approving review for minor pull requests #1135

merged 1 commit into from
Sep 23, 2024

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Sep 23, 2024

Closes #1118. I've already updated our branch protection rules to require only one approving review and to not dismiss "stale" reviews.

Changes proposed in this pull request:

  • Drop mention of prefixes for PR titles. We use tags these days.
  • Say we only typically require one review, except for substantial PRs.

@tsalo tsalo added documentation issues related to improving documentation for the project maintenance issues related to versioning, dependencies, and other related elements labels Sep 23, 2024
@tsalo tsalo merged commit e7a1584 into ME-ICA:main Sep 23, 2024
14 checks passed
@tsalo tsalo deleted the change-branch-protection branch September 23, 2024 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eurunuela eurunuela eurunuela approved these changes

Assignees
No one assigned
Labels
documentation issues related to improving documentation for the project maintenance issues related to versioning, dependencies, and other related elements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Overhaul branch protection rules
2 participants
@tsalo @eurunuela