Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Fixed nuissance typos

Co-authored-by: Taylor Salo <[email protected]>
  • Loading branch information
handwerkerd and tsalo authored Jul 30, 2024
1 parent be89f1e commit 5334875
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@
\node(chrej9)[changeclass, below of=9, xshift=0cm, yshift=-2cm]{Provisional reject};
\node(chacc9)[changeclass, right of=9, xshift=3cm, yshift=0cm]{Provisional accept};
% ----- node: 10
\node(10)[decision, below of=chacc9,label={150:$node\ 10$},label={[align=center] 310: Reject if\\fits external\\nuissance\\regressors},yshift=-2cm]{F test for\\Nuisance Regressors\\$p_{Full} \leq 0.05$\\$R^2_{Full} \geq 0.5$};
\node(10)[decision, below of=chacc9,label={150:$node\ 10$},label={[align=center] 310: Reject if\\fits external\\nuisance\\regressors},yshift=-2cm]{F test for\\Nuisance Regressors\\$p_{Full} \leq 0.05$\\$R^2_{Full} \geq 0.5$};
\node(chrej10)[changeclass, below of=10, xshift=0cm, yshift=-2cm, align=center]{External regressors\\$\rightarrow$Provisional reject};
% ----- node: 11
\node(11)[decision, left of=chrej10,label={180:$node\ 11$},xshift=-3cm]{Partial F test for\\Motion Regressors\\$p_{Full} \leq 0.05$\\$R^2_{Full} \geq 0.5$\\$p_{Motion} \leq 0.05$};
Expand Down
4 changes: 2 additions & 2 deletions docs/included_decision_trees.rst
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,9 @@ there are two demonstration decision trees that implement this new functionality
While these might work well, since they have not yet been validated on data, they
are labeled ``demo``.
``decision_tree_demo_external_regressors_single_model``
demonstrates fitting all nuissance regressors to a single model.
demonstrates fitting all nuisance regressors to a single model.
``decision_tree_demo_external_regressors_motion_task_models``
demonstrates fitting nuissance regressors to a model,
demonstrates fitting nuisance regressors to a model,
partial tests and tagging for components that fit Motion or CSF regressors,
and retention of some components that fit task regressors.

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
"external_regressor_config": [
{
"regress_ID": "nuisance",
"info": "Fits all external nuissance regressors to a single model using an F statistic",
"info": "Fits all external nuisance regressors to a single model using an F statistic",
"report": "External nuisance regressors that fit to components using a linear model were rejected.",
"detrend": true,
"statistic": "F",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
"external_regressor_config": [
{
"regress_ID": "nuisance",
"info": "Fits all external nuissance regressors to a single model using an F statistic",
"info": "Fits all external nuisance regressors to a single model using an F statistic",
"report": "External nuisance regressors that fit to components using a linear model were rejected.",
"detrend": true,
"statistic": "F",
Expand Down
2 changes: 1 addition & 1 deletion tedana/tests/test_component_selector.py
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ def dicts_to_test(treechoice):
{
"regress_ID": "nuisance",
"info": (
"Fits all external nuissance regressors to "
"Fits all external nuisance regressors to "
"a single model using an F statistic"
),
"report": (
Expand Down

0 comments on commit 5334875

Please sign in to comment.