fix transform of mouse position with rotated capture area #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, thanks for the PR and sorry you had to make one due to such a stupid oversight on my part. The change is obviously for the better, and I'll throw it in right away. I'm still new to gamedev and SubViewport is a bit confusing for me, so the quality of the code probably leaves a lot to be desired. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was kinda wondering why the third dimension for the transform was left out?
I tried using this with a rotated capture area and it did not work as expected. Adding in the z axis fixed this.
Just beware that I did not actually test the cs-Code, as I translated it to gdscript for myself ^^
Not sure about the mouse"Outside"-Part, as it only seems to be triggered when I move the mouse very fast.