Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-711: Completion of fundamental Payment Adjuster and its peripheries #442

Open
wants to merge 199 commits into
base: master
Choose a base branch
from
Open

GH-711: Completion of fundamental Payment Adjuster and its peripheries #442

wants to merge 199 commits into from

Conversation

bertllll
Copy link
Contributor

No description provided.

Bert added 30 commits May 4, 2023 18:32
GH-554: rough infrastructure for PaymentAdjuster; almost get first ro…
81eec66 
…und test running
GH-672: simplifying GH-554, let's go on without the Neighborhood invo…
6961653 
…lved for the time being
GH-672: PaymentAdjusterMock and the supertrait with ScannerEtensions …
a60c3ae 
…implemented for a try
GH-672-with-trait-impl-and-generics: perhaps going in the right direc…
bae8ba7 
…tion
GH-672-best-methodology-found: implementation works
752364c
GH-672: first version of adjustment implemented
a63b4a3
GH-672: finished implementing the main test; not refactored yet
279c2a0
GH-672: payment adjuster refactored; tuning logging; but wanna master…
f51de9b 
… features that are missing here
GH-672: master got in now
d99fd45
GH-672: some logging integrated
0a7dc32
GH-672: fine debug log
89dc99a
GH-672: interim commit
d448ece
GH-672: interim commit
0f45f2e
GH-672: another package of big changes (partly-private msgs; payment …
a0f22c3 
…adjuster)
GH-672: decent debug log for adjusted payables
b076bee
GH-672: broadening the adjustment capabilities with gas; rough framework
58db009
GH-672: savepoint; before experimenting with early gas_limit computation
8f5c604
GH-672: continuing in implementation of the check for gas availability.
557c51f
GH-672: merged master in
f5ab24e
GH-672: some renaming and moving files
5547fda
GH-672: almost completed but there is a cenceptual error; maybe extra…
4c322ae 
… tests for BlockchainInterfaceClandestine should be made first
GH-672: last details; adding tests for untested code from BlockchainI…
05eb924 
…nterfaceClandestine
GH-672: almost done; some refactoring ahead
87b7ac9
GH-672: heading to auto-review
ab0b1d8
GH-672: auto review findings
2545ca9
GH-672: refactored scan scheduling code
66a5b54
GH-711: just a log fixed in test
c90355e
GH-711: working on the recursive function adjusting accounts; still w…
022f5d4 
…ith some missing features
GH-711: debug machinery improved and works right
449e196
GH-711: interim commit
81c2191
utkarshg6
utkarshg6 reviewed Jul 19, 2024
View reviewed changes
Copy link
Collaborator

@utkarshg6 utkarshg6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

node/src/accountant/payment_adjuster/miscellaneous/account_stages_conversions.rs:26

utkarshg6
utkarshg6 reviewed Jul 26, 2024
View reviewed changes
Copy link
Collaborator

@utkarshg6 utkarshg6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

node/src/accountant/payment_adjuster/adjustment_runners.rs:118

utkarshg6
utkarshg6 reviewed Jul 26, 2024
View reviewed changes
Copy link
Collaborator

@utkarshg6 utkarshg6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:)

utkarshg6
utkarshg6 reviewed Aug 1, 2024
View reviewed changes
Copy link
Collaborator

@utkarshg6 utkarshg6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

node/src/accountant/payment_adjuster/logging_and_diagnostics/diagnostics.rs:103

utkarshg6
utkarshg6 reviewed Aug 2, 2024
View reviewed changes
Copy link
Collaborator

@utkarshg6 utkarshg6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

node/src/accountant/payment_adjuster/disqualification_arbiter.rs:383

utkarshg6
utkarshg6 reviewed Aug 5, 2024
View reviewed changes
Copy link
Collaborator

@utkarshg6 utkarshg6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Continue at node/src/accountant/payment_adjuster/miscellaneous/helper_functions.rs:120

utkarshg6
utkarshg6 reviewed Aug 6, 2024
View reviewed changes
Copy link
Collaborator

@utkarshg6 utkarshg6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Continue at node/src/accountant/payment_adjuster/mod.rs:87

utkarshg6
utkarshg6 reviewed Aug 6, 2024
View reviewed changes
Copy link
Collaborator

@utkarshg6 utkarshg6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Continue at node/src/accountant/payment_adjuster/mod.rs:203

utkarshg6
utkarshg6 reviewed Aug 7, 2024
View reviewed changes
Copy link
Collaborator

@utkarshg6 utkarshg6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Continue at node/src/accountant/payment_adjuster/mod.rs:277

utkarshg6
utkarshg6 reviewed Aug 8, 2024
View reviewed changes
Copy link
Collaborator

@utkarshg6 utkarshg6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Continue at node/src/accountant/payment_adjuster/mod.rs:422

utkarshg6
utkarshg6 reviewed Aug 9, 2024
View reviewed changes
Copy link
Collaborator

@utkarshg6 utkarshg6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Continue at node/src/accountant/payment_adjuster/mod.rs:807

utkarshg6
utkarshg6 reviewed Aug 15, 2024
View reviewed changes
Copy link
Collaborator

@utkarshg6 utkarshg6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Continue at node/src/accountant/payment_adjuster/mod.rs:1045

utkarshg6
utkarshg6 reviewed Aug 16, 2024
View reviewed changes
Copy link
Collaborator

@utkarshg6 utkarshg6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Continue at node/src/accountant/payment_adjuster/mod.rs:1194

utkarshg6
utkarshg6 reviewed Aug 22, 2024
View reviewed changes
Copy link
Collaborator

@utkarshg6 utkarshg6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Continue at node/src/accountant/payment_adjuster/mod.rs:1258

utkarshg6
utkarshg6 reviewed Aug 23, 2024
View reviewed changes
Copy link
Collaborator

@utkarshg6 utkarshg6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Continue at node/src/accountant/payment_adjuster/mod.rs: 1664

utkarshg6
utkarshg6 reviewed Aug 25, 2024
View reviewed changes
Copy link
Collaborator

@utkarshg6 utkarshg6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Continue at node/src/accountant/payment_adjuster/mod.rs:1917

utkarshg6
utkarshg6 reviewed Aug 29, 2024
View reviewed changes
Copy link
Collaborator

@utkarshg6 utkarshg6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Continue at node/src/accountant/payment_adjuster/mod.rs:2060

utkarshg6
utkarshg6 reviewed Aug 30, 2024
View reviewed changes
Copy link
Collaborator

@utkarshg6 utkarshg6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

node/src/accountant/payment_adjuster/mod.rs:2191

utkarshg6
utkarshg6 reviewed Sep 1, 2024
View reviewed changes
utkarshg6
utkarshg6 reviewed Sep 5, 2024
View reviewed changes
Copy link
Collaborator

@utkarshg6 utkarshg6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Continue from node/src/accountant/payment_adjuster/non_unit_tests/mod.rs:295

utkarshg6
utkarshg6 reviewed Sep 5, 2024
View reviewed changes
Copy link
Collaborator

@utkarshg6 utkarshg6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Continue at node/src/accountant/payment_adjuster/non_unit_tests/mod.rs:628

utkarshg6
utkarshg6 reviewed Sep 6, 2024
View reviewed changes
Copy link
Collaborator

@utkarshg6 utkarshg6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Continue at node/src/accountant/payment_adjuster/preparatory_analyser/mod.rs

utkarshg6
utkarshg6 reviewed Sep 6, 2024
View reviewed changes
Copy link
Collaborator

@utkarshg6 utkarshg6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Continue at node/src/accountant/payment_adjuster/preparatory_analyser/mod.rs:535

utkarshg6
utkarshg6 reviewed Sep 8, 2024
View reviewed changes
Copy link
Collaborator

@utkarshg6 utkarshg6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Continue at node/src/accountant/scanners/mod.rs:325

utkarshg6
utkarshg6 reviewed Sep 8, 2024
View reviewed changes
Copy link
Collaborator

@utkarshg6 utkarshg6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally, it's done! 👏

You don't know how happy I am.

Good Luck with the changes, I wish you'll enjoy the process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@utkarshg6 utkarshg6 utkarshg6 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bertllll @utkarshg6