Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update notebooks to point at titiler-pgstac.maap-project.org instead of titiler.maap-project.org #451

Closed
4 tasks done
hrodmn opened this issue Oct 24, 2024 · 3 comments · May be fixed by #452
Closed
4 tasks done
Assignees

Comments

@hrodmn
Copy link
Contributor

hrodmn commented Oct 24, 2024

@wildintellect
Copy link
Collaborator

@hrodmn if we're merging the functionality, then don't we just need to deploy titiler-pgstac to the original titiler.maap-project.org and call it done?

@hrodmn
Copy link
Contributor Author

hrodmn commented Oct 28, 2024

@hrodmn if we're merging the functionality, then don't we just need to deploy titiler-pgstac to the original titiler.maap-project.org and call it done?

titiler-pgstac.maap-project.org has all* of the endpoints that we supported at the titiler.maap-project.org deployment, so in theory we could just flip a switch and point all titiler.maap-project.org to the titiler-pgstac Lambda.
* /cog/crop -> /cog/bbox

I suppose we can pick whatever url we want to stick with long-term and associate it with the titiler-pgstac deployment. I can see advantages/disadvantages to either url:

titiler.maap-project.org:

  • advantages
    • users do not need to update urls in notebooks
  • disadvantages
    • once we flip the switch it could break functionality for a few limited use-cases

titiler-pgstac.maap-project.org:

  • advantages
    • keeping the new domain would allow us to add some deprecation warnings to responses in titiler.maap-project.org endpoints
      • enables a "phaseout" period for titiler.maap-project.org
    • no changes required to domain name infrastructure, just need to tear down titiler.maap-project.org at some point
  • disadvantages
    • somewhat clunky domain name
    • adding a "phaseout period" where we maintain both APIs but add deprecation warnings might be more trouble than it is worth

@wildintellect
Copy link
Collaborator

Decided to not do this until we know what domain we want to use.

@wildintellect wildintellect closed this as not planned Won't fix, can't repro, duplicate, stale Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants