Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optimize database call #2066

Merged
merged 3 commits into from
Dec 3, 2023
Merged

Add optimize database call #2066

merged 3 commits into from
Dec 3, 2023

Conversation

ildyria
Copy link
Member

@ildyria ildyria commented Dec 2, 2023

Add optimization call so that Large databases can be optimized from the webinterface via an authenticated Get request.

@ildyria ildyria requested a review from a team December 2, 2023 22:05
Copy link

codecov bot commented Dec 2, 2023

Codecov Report

Merging #2066 (f9df33a) into master (5424abc) will decrease coverage by 0.18%.
The diff coverage is 94.73%.

Additional details and impacted files

'mysql' => 'OPTIMIZE TABLE ',
'pgsql' => 'VACUUM(FULL, ANALYZE)',
'sqlite' => 'VACUUM',
default => 'NOTHING',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you use null or something like this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed with 4e7408f and f9df33a.

@ildyria ildyria requested a review from qwerty287 December 3, 2023 12:06
@ildyria ildyria added the Review: easy Easy review expected: probably just need a quick to go through. label Dec 3, 2023
@qwerty287 qwerty287 merged commit be930d1 into master Dec 3, 2023
@qwerty287 qwerty287 deleted the optimize-db-action branch December 3, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Review: easy Easy review expected: probably just need a quick to go through.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants