Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

License as enum type #2025

Merged
merged 8 commits into from
Sep 23, 2023
Merged

License as enum type #2025

merged 8 commits into from
Sep 23, 2023

Conversation

ildyria
Copy link
Member

@ildyria ildyria commented Sep 22, 2023

Use proper enum type instead of array of values..

Extracted from Livewire branch :)

@ildyria ildyria added this to the 4.13 milestone Sep 22, 2023
@ildyria ildyria added the Review: easy Easy review expected: probably just need a quick to go through. label Sep 22, 2023
@ildyria ildyria requested a review from a team September 22, 2023 23:42
@codecov
Copy link

codecov bot commented Sep 23, 2023

Codecov Report

Merging #2025 (daf5010) into master (5f00cbb) will decrease coverage by 0.39%.
The diff coverage is 79.72%.

Additional details and impacted files

@ildyria ildyria changed the title License as type License as enum type Sep 23, 2023
@ildyria ildyria merged commit 4c4745f into master Sep 23, 2023
@ildyria ildyria deleted the license-as-type branch September 23, 2023 09:03
@SerenaButler
Copy link
Contributor

I got an error on my gallery page: "CC-BY-NC-ND" is not a valid backing value for enum "App\Enum\LicenseType"

I added "case CC_BY_NC_ND = 'CC-BY-NC-ND';" and "self::CC_BY_NC_ND->value => 'CC Attribution-NonCommercial-NoDerivatives'," and it is working again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Review: easy Easy review expected: probably just need a quick to go through.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants