replace layout and overlay to proper Enum types #2015
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The layout was using int: 0,1,2.
This created some weird php trickery where we could not make the difference between:
and
Due to type inference, php would assume that the arrays are the same, while the intent is not there.
The keys in that specific case are the intended config option and the value are the translations.
This is breaking and making code complex on Livewire front-end.
By changing this to proper Enum types, we are making the configuration cleaner.
Because this is a migration change. This will in 4.12.0