Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor changes & code refactoring #2010

Merged
merged 3 commits into from
Sep 14, 2023
Merged

Minor changes & code refactoring #2010

merged 3 commits into from
Sep 14, 2023

Conversation

ildyria
Copy link
Member

@ildyria ildyria commented Sep 11, 2023 •
edited
Loading

  • add check if Xdebug is enabled.
  • remove dead code
  • add names for the download routes
  • remove webmix (unused)
  • misc.

@ildyria ildyria requested a review from a team September 11, 2023 17:38
@ildyria ildyria self-assigned this Sep 11, 2023
@ildyria ildyria added the Review: easy Easy review expected: probably just need a quick to go through. label Sep 11, 2023
@ildyria ildyria added this to the 4.11.2 milestone Sep 11, 2023
@codecov
Copy link

codecov bot commented Sep 11, 2023 •
edited
Loading

Codecov Report

Merging #2010 (0c0b109) into master (6285da9) will increase coverage by 1.51%.
The diff coverage is 9.67%.

Additional details and impacted files

@ildyria ildyria mentioned this pull request Sep 11, 2023
Merged
@ildyria ildyria merged commit 49c1667 into master Sep 14, 2023
@ildyria ildyria deleted the port-non-livewire-changes branch September 14, 2023 19:51
@ildyria ildyria modified the milestones: 4.11.2, 4.12.0 Sep 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qwerty287 qwerty287 qwerty287 approved these changes

Assignees

@ildyria ildyria

Labels
Review: easy Easy review expected: probably just need a quick to go through.
Projects
None yet
Milestone
4.12.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ildyria @qwerty287