Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a sample image without extension that will be used in tests. #1863

Merged
merged 1 commit into from
May 25, 2023
Merged

Add a sample image without extension that will be used in tests. #1863

merged 1 commit into from
May 25, 2023

Conversation

wladif
Copy link
Contributor

@wladif wladif commented May 25, 2023 •
edited
Loading

Part of the fix for #1652. Prerequisite for the PR #1864 .

Part of the fix for #1652
5964ae7 
Add a sample image without extension that will be used in tests.
@wladif wladif mentioned this pull request May 25, 2023
Closed
@wladif wladif marked this pull request as ready for review May 25, 2023 07:32
@codecov
Copy link

codecov bot commented May 25, 2023

Codecov Report

Merging #1863 (5964ae7) into master (a3423b6) will decrease coverage by 0.69%.
The diff coverage is n/a.

Additional details and impacted files

qwerty287
qwerty287 approved these changes May 25, 2023
View reviewed changes
Copy link
Contributor

@qwerty287 qwerty287 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this, but if it's unused for now I'd rather do it in #1864 directly.

@wladif
Copy link
Contributor Author

wladif commented May 25, 2023 •
edited
Loading

I'm fine with this, but if it's unused for now I'd rather do it in #1864 directly.

I would prefer the same, but I don't know an easy way to make the test pass on both builds for PR & for merge into master (with just one PR and an image stored in this repository...)
I was inspired by this which I believe points to the master branch.

@ildyria ildyria merged commit 1a0b831 into LycheeOrg:master May 25, 2023
@wladif wladif deleted the test-dependecy branch May 26, 2023 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qwerty287 qwerty287 qwerty287 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wladif @qwerty287 @ildyria