-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for custom headers #161
feat: add support for custom headers #161
Conversation
I forgot to run |
thanks, looks good! |
Reading the original motivation for this (#71), it seems like adding a an The But beyond those, what other custom headers are really needed? Authentication? |
We have been using it to set a Cookie that controls how Apache looks at the login sessions |
Should I make some changes, or what is the status of this? @Lusitaniae I could add the accept header (defaulting to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Do I need to do something? |
No need, many thanks Merged and released in https://github.com/Lusitaniae/apache_exporter/releases/tag/v1.0.0 if you'd like to test |
Perfect, thank you :) |
Example:
This is something we use at work and wanted to share :)
#71