Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix samd TX pin config, fix #35 #36

Merged
merged 2 commits into from
Jan 17, 2022
Merged

Fix samd TX pin config, fix #35 #36

merged 2 commits into from
Jan 17, 2022

Conversation

nicolas-rabault
Copy link
Member

@nicolas-rabault nicolas-rabault commented Jan 17, 2022 •
edited
Loading

🛠️ Fix: SAMD21 board don't high impedance TX pin when TX is disabled #35







!!! WARNING : DO NOT EDIT THE CHECKLIST BELOW !!!

Checklist : Merge from DEVELOP branch

Code Quality

  • Each function has a header (description, inputs, outputs)
  • Code is commented (particularly in hard to understand areas)
  • There are no new warnings that can be corrected
  • Commits policy is respected (constitancy commits, clear commits comments)


Tests Review

  • Manual Tests for new features have been reviewed
  • Automatic Tests for new features have been reviewed


Tests are passed the best as I can

  • Non regression existing tests are passed OK
  • New tests for new features & bug fixes are passed OK


Documentation

  • Documentation is up to date
  • Changelog for next release is up-to-date : fill here
  • If needed, tests are briefly described in test repository

@nicolas-rabault
Copy link
Member Author

@Salem-Luos I have not tested the non-Arduino configuration.
Can you check my code and test it for me, please?

@nicolas-rabault nicolas-rabault self-assigned this Jan 17, 2022
Salem-Tho
Salem-Tho requested changes Jan 17, 2022
View reviewed changes
ATSAMD21_ARDUINO/luos_hal.c Show resolved Hide resolved
ATSAMD21/luos_hal.c Show resolved Hide resolved
@JeromeGalan JeromeGalan merged commit 9313ce5 into release/rc/5.0.1 Jan 17, 2022
@JeromeGalan JeromeGalan deleted the fix/samd_tx_pin_config branch January 17, 2022 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Salem-Tho Salem-Tho Salem-Tho approved these changes

@JeromeGalan JeromeGalan JeromeGalan approved these changes

Assignees

@nicolas-rabault nicolas-rabault

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nicolas-rabault @Salem-Tho @JeromeGalan