Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MapPNextStructHandles should traverse chain till end #1994

Merged
merged 1 commit into from
Jan 28, 2025
Merged

MapPNextStructHandles should traverse chain till end #1994

merged 1 commit into from
Jan 28, 2025

Conversation

panos-lunarg
Copy link
Contributor

No description provided.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 356903.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 5936 running.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 5936 passed.

MarkY-LunarG
MarkY-LunarG approved these changes Jan 27, 2025
View reviewed changes
Copy link
Contributor

@MarkY-LunarG MarkY-LunarG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but Zulauf should really look this over as well since he's actively still working the codegen.

@panos-lunarg
Copy link
Contributor Author

LGTM, but Zulauf should really look this over as well since he's actively still working the codegen.

Saw your name in git blame on neighboring lines and summoned you.
I am a bit concerned that this wasn't detected earlier.

@MarkY-LunarG
Copy link
Contributor

LGTM, but Zulauf should really look this over as well since he's actively still working the codegen.

Saw your name in git blame on neighboring lines and summoned you. I am a bit concerned that this wasn't detected earlier.

Yes, apparently our tests aren't good enough to catch this. This was part of the code refactor and we've caught other errors, but this is the concern that as we touch code we'll have things slip in like this. Good catch.

@wpaul-samsung wpaul-samsung mentioned this pull request Jan 27, 2025
Closed
@panos-lunarg panos-lunarg merged commit 03695a3 into LunarG:dev Jan 28, 2025
9 checks passed
@panos-lunarg panos-lunarg deleted the MapPNextStructHandles_should_traverse_chain_till_end branch January 28, 2025 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkY-LunarG MarkY-LunarG MarkY-LunarG approved these changes

@bradgrantham-lunarg bradgrantham-lunarg bradgrantham-lunarg approved these changes

@jzulauf-lunarg jzulauf-lunarg Awaiting requested review from jzulauf-lunarg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@panos-lunarg @ci-tester-lunarg @MarkY-LunarG @bradgrantham-lunarg