Dx12 dump resources only after draw calls #1952
Conversation
|
CI gfxreconstruct build queued with queue ID 344132. |
|
CI gfxreconstruct build # 5780 running. |
|
CI gfxreconstruct build # 5780 failed. |
davidlunarg
requested review from
locke-lunarg,
davidd-lunarg and
bradgrantham-lunarg
|
I'd like @panos-lunarg to have a chance to offer comment, especially on anything that might change what other users see from Vulkan dump resources. |
| std::string file_name_sub = | ||
| file_name + "_sub_" + std::to_string(sub_index) + (suffix == "" ? ".txt" : ("_" + suffix + ".txt")); | ||
| file_name_sub += (suffix == "" ? ".txt" : ("_" + suffix + ".txt")); |
There was a problem hiding this comment.
Add (suffix == "" ? ".txt" : ("_" + suffix + ".txt")) twice. We could have a function for (suffix == "" ? ".txt" : ("_" + suffix + ".txt")) to reduce the duplicated code.
There was a problem hiding this comment.
Good find. Fixed in subsequent commit. I don't have good test for this case, can you supply one?
Will squash this commit before merging to dev.
|
CI gfxreconstruct build queued with queue ID 355121. |
|
CI gfxreconstruct build # 5921 running. |
This PR should not change the behavior of Vulkan dump resources. The --dump-resources-before-draw option is being added to dx12 and any difference in Vulkan dump resources would be a bug. |
|
CI gfxreconstruct build # 5921 failed. |
| @@ -71,6 +71,7 @@ struct ReplayOptions | |||
| int32_t num_pipeline_creation_jobs{ 0 }; | |||
| std::string asset_file_path; | |||
| std::string dump_resources_output_dir; | |||
| bool dump_resources_before{ false }; | |||
There was a problem hiding this comment.
This variable is now common so it can be removed from vulkan_replay_options.h
There was a problem hiding this comment.
I'd like @panos-lunarg to have a chance to offer comment, especially on anything that might change what other users see from Vulkan dump resources.
These changes look fine from the Vulkan perspective
|
CI gfxreconstruct build queued with queue ID 357404. |
|
CI gfxreconstruct build # 5944 running. |
|
CI gfxreconstruct build # 5944 failed. |
Add --dump-resources-before-draw command line option: Enables dumping resources before draw calls
davidlunarg
force-pushed
the
davidp_dx12_dump_only_after
branch
from
439b356 to
11c06eb
Compare
|
CI gfxreconstruct build queued with queue ID 357660. |
|
CI gfxreconstruct build # 5946 running. |
|
CI gfxreconstruct build # 5946 failed. |
No description provided.