Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set pipelines to VK_NULL_HANDLE when VK_PIPELINE_CREATE_FAIL_ON_PIPELINE_COMPILE_REQUIRED_BIT isnt supported #1938

Merged
merged 1 commit into from
Dec 25, 2024

Conversation

ziga-lunarg
Copy link
Contributor

No description provided.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 330779.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 5645 running.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 5645 passed.

@ziga-lunarg ziga-lunarg force-pushed the ziga-fix-fail-on-compile branch from 178da43 to 87f29d1 Compare December 23, 2024 11:58
@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 330806.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 5646 running.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 5646 passed.

@bradgrantham-lunarg
Copy link
Contributor

For reference this is the applicable spec language from vkCreateGraphicsPipelines:

VK_PIPELINE_CREATE_FAIL_ON_PIPELINE_COMPILE_REQUIRED_BIT specifies that pipeline creation will fail if a compile is required for creation of a valid [VkPipeline](https://registry.khronos.org/vulkan/specs/1.3-extensions/html/vkspec.html#VkPipeline) object; VK_PIPELINE_COMPILE_REQUIRED will be returned by pipeline creation, and the [VkPipeline](https://registry.khronos.org/vulkan/specs/1.3-extensions/html/vkspec.html#VkPipeline) will be set to [VK_NULL_HANDLE](https://registry.khronos.org/vulkan/specs/1.3-extensions/html/vkspec.html#VK_NULL_HANDLE).

@ziga-lunarg ziga-lunarg merged commit 599920e into LunarG:dev Dec 25, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants