Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Beau null test driver #1886

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

Beau null test driver #1886

wants to merge 3 commits into from

Conversation

beau-lunarg
Copy link
Contributor

No description provided.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 309411.

@beau-lunarg beau-lunarg marked this pull request as ready for review November 25, 2024 22:44
@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 5383 running.

@beau-lunarg beau-lunarg force-pushed the beau-null-test-driver branch from 1481cba to 6dc4241 Compare November 25, 2024 23:01
@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 309432.

@beau-lunarg beau-lunarg force-pushed the beau-null-test-driver branch from 6dc4241 to dc0ae2d Compare November 25, 2024 23:32
@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 309453.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 5387 running.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 5387 failed.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 310385.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 5403 running.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 5403 failed.

@beau-lunarg beau-lunarg force-pushed the beau-null-test-driver branch from cab8f33 to 5c97adc Compare November 26, 2024 20:26
@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 310517.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 5405 running.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 5405 failed.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 311640.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 5423 running.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 311671.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 311674.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 311707.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 311729.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 311733.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 311751.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 311754.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 311757.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 311791.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 311811.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 311817.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 311852.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 354266.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 354310.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 5915 running.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 5915 passed.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 355046.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 5919 running.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 5919 aborted.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 355065.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 5920 running.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 355084.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 355084 cancelled.

@beau-lunarg beau-lunarg force-pushed the beau-null-test-driver branch from bbf4dd1 to c2b4269 Compare January 24, 2025 17:22
@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 5915 passed.

@beau-lunarg beau-lunarg force-pushed the beau-null-test-driver branch from c2b4269 to 0837f47 Compare January 24, 2025 21:08
@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 355515.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 357188.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 5942 running.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 5942 passed.

MarkY-LunarG
MarkY-LunarG reviewed Jan 30, 2025
View reviewed changes
test/verify-gfxr.h
Comment on lines +4 to +19
/*
* Run an application with capture enabled, and compare the resulting gfxr file to a known good gfxr
*
* app_run_directory - the directory to run the application from, relative to test_apps folder
* app_path - the path to the application, relative to app_run_directory
* known_gfxr_path - path to the known good gfxr file, relative to the known_good folder
*
* expects the following environment variables to be set
* VK_LAYER_PATH - path to VkLayer_gfxreconstruct.dll
* VK_DRIVER_FILES - path to VkICD_mock_icd.json
*
* expects the following environment variables to be set with the following values
* VK_INSTANCE_LAYERS=VK_LAYER_LUNARG_gfxreconstruct
* GFXRECON_CAPTURE_FILE_TIMESTAMP=false
* GFXRECON_CAPTURE_FILE=actual.gfxr
*/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A+ on the comment. I wish we had more this clear.

MarkY-LunarG
MarkY-LunarG approved these changes Jan 30, 2025
View reviewed changes
Copy link
Contributor

@MarkY-LunarG MarkY-LunarG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know about the YAML files so I can't say much about those. But in general everything looks good. Just a few questions, but nothing blocking approval.

test/test_apps/common/test_app_base.cpp
Comment on lines -809 to -818
#if defined(VK_KHR_portability_enumeration)
bool portability_enumeration_support =
detail::check_extension_supported(system.available_extensions, VK_KHR_PORTABILITY_ENUMERATION_EXTENSION_NAME);
if (portability_enumeration_support)
{
extensions.push_back(VK_KHR_PORTABILITY_ENUMERATION_EXTENSION_NAME);
}
#else
bool portability_enumeration_support = false;
#endif
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you just planning on no supporting MoltenVK or is this just no longer needed?

test/test_apps/common/test_app_base.cpp Show resolved Hide resolved
test/icd/README.md
@@ -0,0 +1,80 @@
# Vulkan Mock ICD

This directory contains a mock ICD driver designed for validation layer testing.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit, not just for "validation layer testing"

@beau-lunarg
Implement Automated Test App testing
273f116 
Add Mock ICD
Add Headless mode to Test Apps
Add Test Runner
Add CICD scripts for running tests in Github Actions
@beau-lunarg
Add instructions for running tests
92f6f71
@beau-lunarg
Fix post rebase
aff002c
@beau-lunarg beau-lunarg force-pushed the beau-null-test-driver branch from e04cfbb to aff002c Compare January 31, 2025 01:50
@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 361396.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 5998 running.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 5998 passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkY-LunarG MarkY-LunarG MarkY-LunarG approved these changes

@bradgrantham-lunarg bradgrantham-lunarg Awaiting requested review from bradgrantham-lunarg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@beau-lunarg @ci-tester-lunarg @MarkY-LunarG