gfxrecon-replay: Use infinite timeout for 3 Vulkan api calls #1239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When replaying:
vkAcquireProfilingLockKHR
vkWaitForPresentKHR
vkWaitSemaphores
use an infinite timeout if the expected result is VK_SUCCESS.
|
CI gfxreconstruct build queued with queue ID 32881. |
|
CI gfxreconstruct build # 3147 running. |
|
CI gfxreconstruct build # 3147 passed. |
Added braces to code changes in 2 prior commits Renamed a variable in VulkanReplayConsumerBase::OverrideAcquireProfilingLockKHR in framework/decode/vulkan_replay_consumer_base.cpp
|
CI gfxreconstruct build queued with queue ID 33915. |
|
CI gfxreconstruct build # 3161 running. |
|
CI gfxreconstruct build # 3161 passed. |
Modify virtual swapchain to create a command buffer per queue and and per swapchain image. Then when a vkQueuePresent occurs, perform the blits in the same queue as the presented queue to reduce race conditions. This resolves the issue where a QueuePresent is presented inline in a queue, but has no wait semaphore information. Instead, the QueuePresent relied upon the previous submit (also in the same queue) to perform the synchronization. Previously, the virtual swapchain had it's own Queue that it used which caused a race condition resulting in old images being used. Fixes: LunarG#1122
* cast a float result back to uint32_t * fix some strict warnings
|
CI gfxreconstruct build queued with queue ID 34079. |
|
CI gfxreconstruct build # 3162 running. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When replaying:
vkAcquireProfilingLockKHR
vkWaitForPresentKHR
vkWaitSemaphores
use an infinite timeout if the expected result is VK_SUCCESS.