Screenshot size during replay is now configurable #1226
Conversation
|
CI gfxreconstruct build queued with queue ID 23008. |
|
CI gfxreconstruct build # 3083 running. |
|
CI gfxreconstruct build # 3083 passed. |
panos-lunarg
force-pushed
the
panos_screenshot_size
branch
from
af377ba to
ab9883b
Compare
|
CI gfxreconstruct build queued with queue ID 23738. |
|
CI gfxreconstruct build # 3087 running. |
|
CI gfxreconstruct build # 3087 passed. |
|
CI gfxreconstruct build queued with queue ID 29559. |
|
CI gfxreconstruct build # 3125 running. |
|
CI gfxreconstruct build queued with queue ID 29572. |
| @@ -92,6 +95,10 @@ void ScreenshotHandler::WriteImage(const std::string& filen | |||
|
|
|||
| VkResult result = VK_SUCCESS; | |||
|
|
|||
| // If both copy_scale and copy_width are provided, use copy_scale. | |||
There was a problem hiding this comment.
I think the function that calls this function is a better location to do this conditional. That is, receive only copy_width and copy_height in this function and calculate it in functions that call this function.
| width = std::stoul(value.substr(0, x)); | ||
| height = std::stoul(value.substr(x + 1)); | ||
| } | ||
| catch (std::exception& e) |
There was a problem hiding this comment.
If any of these exceptions happened, that means we couldn't parse the screenshot size, right? I think the user probably needs to be warned in each of these cases.
|
Note that you may get a conflict with #1205, so please be cognizant of that PR if it goes in first. |
|
CI gfxreconstruct build # 3126 running. |
|
CI gfxreconstruct build # 3126 passed. |
panos-lunarg
force-pushed
the
panos_screenshot_size
branch
from
9bfdcdb to
74cbcc4
Compare
|
CI gfxreconstruct build queued with queue ID 30136. |
|
CI gfxreconstruct build # 3133 running. |
|
CI gfxreconstruct build # 3133 passed. |
Adds two new replay options that controls the screenshot dimensions: --screenshot-size <width>x<height> explicitly sets the dimensions of the generated screenshot --screenshot-scale <number> Scales the swapchain images by that number. Number can be decimal
panos-lunarg
force-pushed
the
panos_screenshot_size
branch
from
74cbcc4 to
b76260d
Compare
|
CI gfxreconstruct build queued with queue ID 31719. |
|
CI gfxreconstruct build # 3141 running. |
|
CI gfxreconstruct build # 3141 passed. |
Adds two new replay options that controls the screenshot dimensions:
--screenshot-size <width>x<height>explicitly sets the dimensions of thegenerated screenshot
--screenshot-scale <number>Scales the swapchain images by that number.Number can be decimal