Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GitHub Actions CI #1389

Closed
wants to merge 1 commit into from
Closed

Add GitHub Actions CI #1389

wants to merge 1 commit into from

Conversation

Margen67
Copy link
Contributor

@Margen67 Margen67 commented Apr 3, 2020 •
edited
Loading

TuxSH
TuxSH requested changes Apr 15, 2020
View reviewed changes
Copy link
Member

@TuxSH TuxSH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, why reinstall everything at every CI trigger? Is it not possible to use a docker image with everything set up instead?

jbmagination referenced this pull request in JBMagination2/Luma3DS Apr 24, 2020
@jbmagination
Add GitHub actions CI from AuroraWright#1389
a297337
@Margen67
Copy link
Contributor Author

Margen67 commented Jun 1, 2020

Thanks to @Nanquitas updating their Docker image this can be done cleanly now.
@jbmagination you might want to use this improved version.

@jbmagination
Copy link

@TuxSH?

Also yes, I will use that version.

@Margen67 Margen67 closed this Sep 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TuxSH TuxSH TuxSH requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Margen67 @jbmagination @TuxSH