Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #129: Wrong architecture for binaries downloaded on ARM Macs #483

Merged
merged 1 commit into from
Mar 18, 2024
Merged

Issue #129: Wrong architecture for binaries downloaded on ARM Macs #483

merged 1 commit into from
Mar 18, 2024

Conversation

justafish
Copy link
Member

@justafish justafish commented Mar 15, 2024 •
edited
Loading

Fixes #129

@github-actions github-actions bot temporarily deployed to pantheon-pr-483 March 15, 2024 15:13 Destroyed
@justafish justafish marked this pull request as ready for review March 15, 2024 15:25
mrdavidburns
mrdavidburns approved these changes Mar 18, 2024
View reviewed changes
Copy link
Member

@mrdavidburns mrdavidburns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm currently not experiencing this error on any projects that I have spun up recently. I've also just got a new M3 Macbook Pro within the last month so all my builds are completely new.

This code looks good and is well documented. I approve.

@mrdavidburns mrdavidburns merged commit e4a4b11 into main Mar 18, 2024
35 checks passed
@mrdavidburns mrdavidburns deleted the justafish/129-wrong-architecture-binaries branch March 18, 2024 18:55
@deviantintegral
Copy link
Member

deviantintegral commented Mar 19, 2024 •
edited
Loading

I tested this and it works!

In a new directory:

$ ddev config
$ ddev start
$ ddev ssh
$ composer require lullabot/drainpipe:dev-main
$ file vendor/bin/task
vendor/bin/task: ELF 64-bit LSB executable, ARM aarch64, version 1 (SYSV), statically linked, Go BuildID=ve0_eO6VCfVbq5fTCdTp/FCvOP6yopFz6F8QKI4lu/fTsOU1PTvfpsaSEWpW-k/xVciGhbgpt6gGPcPrtSF, stripped

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrdavidburns mrdavidburns mrdavidburns approved these changes

@deviantintegral deviantintegral Awaiting requested review from deviantintegral

@davereid davereid Awaiting requested review from davereid

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong architecture for binaries downloaded on ARM Macs
3 participants
@justafish @deviantintegral @mrdavidburns