Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #410: Install the redis PHP extension in Tugboat #433

Merged
merged 5 commits into from
Feb 21, 2024

Conversation

justafish
Copy link
Member

@justafish justafish commented Feb 19, 2024

Fixes #410

@github-actions github-actions bot temporarily deployed to pantheon-pr-433 February 19, 2024 14:40 Destroyed
@github-actions github-actions bot temporarily deployed to pantheon-pr-433 February 19, 2024 14:49 Destroyed

apt-get install -y zlib1g-dev
pecl install memcache
yes '' | pecl install -f memcache
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, I've never needed to do any of this in tugboat or CI - just pecl install <something>. What's up here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it should run fine in non-interactive mode, but won't run without asking questions if you put that directly into the tugboat terminal - bit hard for me to test at the moment with our setup so just left it at what I can test directly

@deviantintegral
Copy link
Member

Test failure is maximum multidev limit: #408

@github-actions github-actions bot temporarily deployed to pantheon-pr-433 February 19, 2024 15:21 Destroyed
@deviantintegral deviantintegral added the enhancement New feature or request label Feb 19, 2024
@github-actions github-actions bot temporarily deployed to pantheon-pr-433 February 20, 2024 14:26 Destroyed
Copy link
Member

@deviantintegral deviantintegral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

I actually expected this to fail tests though, given there's no corresponding test update.

@justafish
Copy link
Member Author

We can only test one combination of Tugboat settings currently

@justafish justafish merged commit 874fe6f into main Feb 21, 2024
31 checks passed
@justafish justafish deleted the justafish/issue-410-redis-tugboat-php-extension branch February 21, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Install the PHP Redis extension when including Redis in Tugboat
2 participants