Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version of Terminus used in Gitlab integration is very old #258

Closed
ABAJosh opened this issue Sep 6, 2023 · 2 comments
Closed

Version of Terminus used in Gitlab integration is very old #258

ABAJosh opened this issue Sep 6, 2023 · 2 comments
Assignees

Comments

@ABAJosh
Copy link
Contributor

ABAJosh commented Sep 6, 2023

Drainpipe currently uses Terminus 3.0.7, while the current version is 3.2.1. We should upgrade to the current version. This is a simple change in the following file: scaffold/gitlab/Pantheon.gitlab-ci.yml

The line:
curl -L https://github.com/pantheon-systems/terminus/releases/download/3.0.7/terminus.phar --output ~/terminus/terminus

should be changed to:
curl -L https://github.com/pantheon-systems/terminus/releases/download/3.2.1/terminus.phar --output ~/terminus/terminus

@justafish
Copy link
Member

@ABAJosh 👋 Could you test this branch on your site and check that it doesn't break anything please? I don't have anything with GitLab setup to hand at the moment 259

@ABAJosh
Copy link
Contributor Author

ABAJosh commented Sep 26, 2023

Tested and verified that Terminus is working as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants