Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch phpstan to include phpstan.neon.dist #249

Closed
deviantintegral opened this issue Aug 22, 2023 · 3 comments · Fixed by #627
Closed

Switch phpstan to include phpstan.neon.dist #249

deviantintegral opened this issue Aug 22, 2023 · 3 comments · Fixed by #627
Assignees
@leonel-lullabot
Labels
bug Something isn't working client affected

Comments

@deviantintegral
Copy link
Member

As I noted at #216, phpstan generally recommends and expects a .dist file to be committed to the repo, and phpstan.neon to be git ignored. As well, PHPStorm throws an error that phpstan.neon.dist doesn't exist.

Instead, lets:

  1. Copy the configuration as phpstan.neon.dist via composer scaffold.
  2. Get rid of -c in our task:static tests.
@davereid
Copy link
Member

davereid commented Jan 8, 2024

Yes, +1 to this, using a phpstan.neon.dist is preferred and what we provided via scaffolding on a shared install profile across several sites, which allows individual projects to still use their own phpstan.neon file that overrides/references the dist file already.

@deviantintegral deviantintegral added bug Something isn't working client affected labels Feb 19, 2024
@deviantintegral
Copy link
Member Author

Same type of issue as #238 .

@davereid davereid self-assigned this May 2, 2024
leonel-lullabot added a commit that referenced this issue Jul 30, 2024
@leonel-lullabot
Issue #249: Remove -c from the phpstan test
5c80596
leonel-lullabot added a commit that referenced this issue Aug 1, 2024
@leonel-lullabot
Issue #249: Scaffold phpstan.neon.dist
67255f6
leonel-lullabot added a commit that referenced this issue Aug 1, 2024
@leonel-lullabot
Issue #249: Update TestStatic.yml
0f74838
leonel-lullabot added a commit that referenced this issue Aug 1, 2024
@leonel-lullabot
Issue #249: Update phpstan.neon.dist
c399c6f
@leonel-lullabot leonel-lullabot mentioned this issue Aug 1, 2024
Merged
@leonel-lullabot
Copy link
Collaborator

PR #627 is ready for review

mrdavidburns pushed a commit that referenced this issue Aug 5, 2024
@leonel-lullabot
Issue #249: Switch phpstan to include phpstan.neon.dist (#627)
cd5d5f6 
* Issue #249: Remove -c from the phpstan test

* Issue #249: Scaffold phpstan.neon.dist

* Issue #249: Update TestStatic.yml

* Issue #249: Update phpstan.neon.dist
mrdavidburns added a commit that referenced this issue Aug 8, 2024
@mrdavidburns
Revert "Issue #249: Switch phpstan to include phpstan.neon.dist (#627)"
ef469c6 
This reverts commit cd5d5f6.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leonel-lullabot leonel-lullabot

Labels
bug Something isn't working client affected
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue #249: Switch phpstan to include phpstan.neon.dist Lullabot/drainpipe
3 participants
@davereid @deviantintegral @leonel-lullabot