Glyph truncation fix

[Dreomite]

Closes #223

I couldn't find any edge-cases, although some extra testing will never hurt.

[crian]

you should push this to suckless st.

tested your commits on my st build and they are working fine.

[Dreomite]

Yeah, I guess it makes sense. I'll contact st devs. Even though, I doubt it will get accepted because this is a pretty rough solution which was written with patches compatibility in mind, so it takes more CPU time than it could have otherwise. A proper implementation would involve a complete refactoring of the drawing part which I'm definitely not up to.

---

I successfully subscribed to [email protected], yet it still doesn't let me post and denies all my emails. Welp ¯\_(ツ)_/¯

[kopr12]

Great patch!
It has one problem though and that's when it's used in combination with anysize patch.
That patch extends the size of the window and centers the actual terminal, thus leaving some space on top and the bottom, so when the glyphs are drawn they leave parts of it on that space, command 'clear' doesn't clear that part.
It's also visible when launching other term apps like neomutt cmus etc.

Now, I removed anysize patch so all is good, but just saying :D

[mortezadadgar]

@Dreomite did you get any respond from suckless devs?

[Dreomite]

It has one problem though and that's when it's used in combination with anysize patch.
That patch extends the size of the window and centers the actual terminal, thus leaving some space on top and the bottom, so when the glyphs are drawn they leave parts of it on that space, command 'clear' doesn't clear that part.
It's also visible when launching other term apps like neomutt cmus etc.

Sorry for not replying to you earlier. Somehow, this message went past me.

This problem could be solved by putting rectangle clipping on the drawable terminal area. Using the same method as in reverted db6f796. But instead of per character clipping, call it once to clip the whole terminal area.

@Dreomite did you get any respond from suckless devs?

Unfortunately, I was not able to contact the devs, because all my emails were automatically rejected. In the end, I unsubscribed from the dev list and called it a day. If someone can bring this [hacky] workaround to their attention, that would be great. I don't have any motivation to do this since I moved to another terminal emulator.