Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
set
function needs improvement. I'm not even sure it is possible to make it in typescript definition files.Problem:
The
path
parameter might be a string, which contains of keys, separated with dot. We'd need to define n-level nesting (Wheren = numberOfDots + 1
) inImmutableSetReturnFromPathString
type somehow. Perhaps it would be a good idea to implement this method in typescript itself, and - if needed - slightly modify it, in order for it to be more "typed-way". wdyt?Another story is: what if a user wants (for
GodKnowsWhy
reason), to have resulting object with key, that contains a dot e.g.Is there a way to do that using
set
method?