Fix regex enforcement false negative bug #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For
@RegularExpressionenforcement, the existing use ofcontainsMatchInis problematic in that it allows unwanted strings.For example, with
Request(@RegularExpression("[0-9]{4}") val fourDigits: String), unwanted string "12345" can pass the validation unexpectedly.This PR also contains a test for the described issue too. I'm not sure if there's a better way and better place to test this enforcement within the exiting test files, so feel free to let me know if any exiting file can host this test case better!