Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump undici from 5.28.4 to 5.28.5 in /examples/auth/custom-oauth2-creds #881

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 22, 2025

Bumps undici from 5.28.4 to 5.28.5.

Release notes

Sourced from undici's releases.

v5.28.5

⚠️ Security Release ⚠️

Fixes CVE CVE-2025-22150 GHSA-c76h-2ccp-4975 (embargoed until 22-01-2025).

Full Changelog: nodejs/undici@v5.28.4...v5.28.5

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

Bumps [undici](https://github.com/nodejs/undici) from 5.28.4 to 5.28.5.
- [Release notes](https://github.com/nodejs/undici/releases)
- [Commits](nodejs/undici@v5.28.4...v5.28.5)

---
updated-dependencies:
- dependency-name: undici
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Jan 22, 2025
@NotTsunami
Copy link

Is there anything stopping us from bumping undici to v6? Afaik, there was no API difference but I believe node 14/16 support was dropped.

@antoniojps
Copy link

Is there anything stopping us from bumping undici to v6? Afaik, there was no API difference but I believe node 14/16 support was dropped.

This would be great specially because the current undici version prevents proxy usage due to this issue nodejs/undici#2542

@absidue
Copy link
Collaborator

absidue commented Feb 1, 2025

Is there anything stopping us from bumping undici to v6? Afaik, there was no API difference but I believe node 14/16 support was dropped.

@NotTsunami The fact that it drops Node.js 16 is a good reason not to upgrade because a quick look at the package.json file will tell you that YouTube.js targets Node.js 16.

@NotTsunami
Copy link

NotTsunami commented Feb 4, 2025

Is there anything stopping us from bumping undici to v6? Afaik, there was no API difference but I believe node 14/16 support was dropped.

@NotTsunami The fact that it drops Node.js 16 is a good reason not to upgrade because a quick look at the package.json file will tell you that YouTube.js targets Node.js 16.

Hadn't noticed, didn't look at the node:bundle command. Node 16 is out of support now, perhaps we could use this as an excuse to bump undici? Looks like Undici v5 goes out of support in April as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file xsmall-diff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants