Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add Luvit #6

Closed
wants to merge 1 commit into from
Closed

add Luvit #6

wants to merge 1 commit into from

Conversation

Bilal2453
Copy link
Contributor

No description provided.

@Bilal2453
Copy link
Contributor Author

Closes #4

@carsakiller
Copy link
Collaborator

Hello! Thanks for the contribution!

Please add an info.json file with a name and description for your addon. The size and hasPlugin can be ignored, as those will be automatically generated. Also, please confirm the code follows StyLua styling.

Need to fix the GitHub action before this can be merged as well

@carsakiller carsakiller linked an issue Mar 4, 2023 that may be closed by this pull request
adding Luvit addon #4
Closed
@carsakiller carsakiller added the New Addon Related to adding a new addon label Mar 4, 2023
@Bilal2453
Copy link
Contributor Author

Ah, thought the file would be added by the GitHub action.

@Bilal2453 Bilal2453 closed this Mar 4, 2023
@Bilal2453
Copy link
Contributor Author

Oops, rebased one commit more accidentally and that automatically closed the PR. Should be good now I believe.

@Bilal2453 Bilal2453 reopened this Mar 4, 2023
@carsakiller
Copy link
Collaborator

Oh boy, now what is wrong with the action? Searching around led me to actions/checkout#455 but I don't think it has trouble with cloning a fork since it looks like it worked for #5

@Bilal2453
Copy link
Contributor Author

Hm, I can possibly try reopening a new PR to see if the action works there, and if it does we can just close this ignoring this has happened

@carsakiller
Copy link
Collaborator

Let's try that. Maybe the ref is messed up following the rebase?

@Bilal2453
Copy link
Contributor Author

Just in case, I will also do this on a different branch than this add-luvit then

@carsakiller
Copy link
Collaborator

Replaced with #7

@carsakiller carsakiller closed this Mar 4, 2023
@Bilal2453 Bilal2453 deleted the add-luvit branch March 7, 2023 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
New Addon Related to adding a new addon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

adding Luvit addon
2 participants
@Bilal2453 @carsakiller