feat(preview): allow changing the preview placement #330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LouisBrunner
approved these changes
Dec 10, 2024
MatheoJaouen
approved these changes
Dec 12, 2024
|
@MPeloquin I had to fight with a few things but your change is now released as v8.1.0 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow moving the preview to different anchor points.
Added the following points:
Also added a way to add padding to the position. (for our case, our designer wanted to have the preview slightly under the top)
Non-breaking changes, all defaults values are the same as the current behavior and all options are optional.
Added tests & updated the example app
See video:
CleanShot.2024-12-10.at.16.19.25.mp4