Allow setting the ID of the notification manually #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LouisBarranqueiro
requested changes
Sep 24, 2016
| @@ -17,7 +17,9 @@ const REMOVE_NOTIFICATION = 'REMOVE_NOTIFICATION'; | |||
| * @returns {Object} notification | |||
| */ | |||
| export const addNotification = (notification) => (dispatch) => { | |||
| notification.id = new Date().getTime(); | |||
| if (notification.id === undefined) { | |||
There was a problem hiding this comment.
use if (!notification.id) { here, it will prevent empty string, null case, etc...
As you can see, L21 is no more covered because we set notification.id to null in the test case : https://coveralls.io/builds/8020458/source?filename=src%2Fstore%2Fnotifications.js#L21
LouisBarranqueiro
requested changes
Sep 24, 2016
LouisBarranqueiro
requested changes
Sep 25, 2016
| @@ -113,12 +114,13 @@ updateNotification(notification); | |||
|
|
|||
| | Parameter | Type | Description | | |||
| | ------------ | -------- | ----------- | | |||
| | notification | Object | A [notification](https://github.com/LouisBarranqueiro/reapop/blob/master/docs/api.md#notification-object-properties-1) object | | |||
| | notification | Object | A [notification](https://github.com/LouisBarranqueiro/reapop/blob/master/docs/api.md#notification-object-properties-1) object or ID of the notification | | |||
There was a problem hiding this comment.
why? If you pass a notification ID, nothing gonna change
LouisBarranqueiro
approved these changes
Sep 25, 2016
|
Great, thanks for merging. When should I expect to see this on NPM? |
|
Just published :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows to set manually the identifier of the notification. The uniqueness of the ID in this case is the responsibility of the user. This does not change any existing behaviour.
Made for this issue: #6
I am not sure on where to add the documentation about this feature, please point me