-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update package.json - added module - fix vite esm build #506
Conversation
👋 @salvoravida Could you please share more information about this fix? What's the context? |
without "module": "dist/reapop.esm.js", that's all. https://github.com/jaredpalmer/tsdx/blob/v0.14.1/src/templates/utils/index.ts#L15 |
the node_env=production is an optimizaiton for the esm build -> https://tsdx.io/optimization
|
@salvoravida also using vite with a react app and seeing the following runtime error:
I'd imagine your fix should help as the default import is not what is expected? |
I dnk, anyway can test my current fork with the fix @salvoravida/reapop 4.2.1 |
@LouisBarranqueiro any updates on this? |
👋 @salvoravida, sorry for the VERY VERY late reply.
I compared builds with and without it and it's the same. I will keep it just in case and check for newer versions if there is a difference. Thanks for the contribution 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @salvoravida)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @salvoravida)
I will update other dependencies and release a new version this WE 🙂 |
Update package.json - added module - fix vite esm build
This change is