Master #8
Merged
Master #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NotePlayHandleManager::acquire uses a read lock unless the pool is empty. If two threads try to acquire NotePlayHandle simultaneously when the value of s_availableIndex is 1, one thread will try to read s_available[-1]. If the acquire action and the release action are done at the same time, NotePlayHandleManager::acquire may try to read data before NotePlayHandleManager::release actually writes. This commit prevents them by always using the write lock when acquiring a NotePlayHandle.
Fixes a regression in 91f9f1a, which added the range check into the wrong if statement.
SampleBuffer was using baseSampleRate as the default samplerate instead of the actual processingSampleRate.
played correctly after saving and loading a project due to sample rate not getting saved in the project file.
right place when it not played from the begining. That has created a difference between the ticks and the metronome and the sample track. The cause of the problem was that the calculation of the frame to play was wrong: we had calculated `framesPerTick` according to the current engine's sample rate instead of the SampleBuffer's sample rate.
appdmg recently dropped support for Node.js < 8.5
Fixes wrongly set 'Blues' genre(ID 0) in exported mp3 files.
Co-Authored-By: Hyunjin Song <[email protected]>
* Fix "Export Tracks" * Add "Export MIDI" [ci skip]
Rebrand macOS DMG background - Design and artwork courtesy @RebeccaDeField - Closes #4289
* Song: add isSavingProject. * VersionedSaveDialog: Add support for a custom option dialog. * AutomatableModel: Support the discardMIDIConnections save option. * InstrumentTrack: Support the discardMIDIConnections save option. * SaveOptions: Show the save option dialog on "save as".
# Conflicts: # data/locale/cs.ts # data/locale/en.ts # data/locale/ko.ts # data/locale/ru.ts # data/locale/uk.ts # data/locale/zh_TW.ts # include/Engine.h # plugins/nes/Nes.cpp # src/core/NotePlayHandle.cpp # src/core/SampleBuffer.cpp # src/tracks/SampleTrack.cpp
* Replace tLimit() with qBound() * Remove templates.h
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.