Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

game-buf: rewrite to use arena allocator #2496

Merged
merged 1 commit into from
Feb 14, 2025
Merged

game-buf: rewrite to use arena allocator #2496

merged 1 commit into from
Feb 14, 2025

Conversation

rr-
Copy link
Collaborator

@rr- rr- commented Feb 13, 2025

Checklist

  • I have read the coding conventions
  • I have added a changelog entry about what my pull request accomplishes, or it is an internal change
  • I have added a readme entry about my new feature or OG bug fix, or it is a different change

Description

A proposal on dropping the fixed-size game buffer capacity, which saves us some 8 ms at the game startup, and should theoretically slightly reduce the game's memory footprint. It changes the game buffer to grow in increments of 5 MB at a time rather than allocating a fixed-size very large buffer.

@rr- rr- self-assigned this Feb 13, 2025
@rr- rr- requested review from a team as code owners February 13, 2025 14:23
@rr- rr- requested review from lahm86, walkawayy and aredfan and removed request for a team February 13, 2025 14:23
@rr- rr- added the Internal The invisible stuff label Feb 13, 2025
src/libtrx/game/game_buf.c Show resolved Hide resolved
src/libtrx/memory.c Show resolved Hide resolved
@rr- rr- merged commit 0e04acd into develop Feb 14, 2025
9 checks passed
@rr- rr- deleted the arena-mem branch February 14, 2025 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Internal The invisible stuff
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants