Unacknowledged command handling fixes and PodCommsSession improvements #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
itsmojo
commented
Nov 18, 2024
itsmojo
commented
- Don't append an optional beep block to a getStatus with a pending unacknowledged command
- Handle unacknowledged commands cases in acknowledgeAlerts(), beepConfig() & configureAlert()
- Use checkCommandAgainstStatus() for seq # mismatch to determine insulin delivery status
- Remove unneeded @discardResult attribute on various PodCommsSessions functions
- Comment improvements and better source code synchronization between OmniKit and OmniBLE
+ Don't append an optional beep block to a getStatus with a pending unacknowledged command + Handle unacknowledged commands cases in acknowledgeAlerts(), beepConfig() & configureAlert() + Use checkCommandAgainstStatus() for seq # mismatch to determine insulin delivery status + Remove unneeded @discardResult attribute on various PodCommsSessions functions + Comment improvements and better source code synchronization between OmniKit and OmniBLE
StatusLGTM Code ReviewThe code review looks good. Also did a comparison of OmniBLE PR 136 and OmniKit PR 45 side-by-side. The only differences between OmniBLE and OmniKit are the rileylink vs Bluetooth differences. Refer to OmniBLE PR 136 for additional comments. |
marionbarker
approved these changes
Dec 8, 2024
This was referenced Jan 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.