1.3.x: Trend arrow missing from current BG value (in header/dashboard) #456
Comments
|
What CGM are you using? |
|
Enlite. It did work before. Tried with the latest Dev bits from approx 24 hours back, and it's still missing |
|
I don't believe we parse arrows on enlite on x22. Are you x23? Have you done a mysentry pairing? |
|
My bad. Should know better than not including basic stuff when reporting issues.. 754 EU pump That's running pre-1.3 (with trend arrow)
|
|
Yes, I think I see what's going on. It was part of the CGM refactor that happened in this version. We track a variable called latestPumpStatusFromMySentry that contains trend from mysentry packets. We still track that var, but the displayed trend arrow comes from sensorState on the cgm data manager (EnliteCGMManager). I think we should get rid of latestPumpStatusFromMySentry, and instead update the instance of EnliteCGMManager with a new sensorState when a mysentry packet comes in, and also make sure to not overwrite sensorState when history cgm data is fetched, unless the history cgm value is newer. I don't run Enlite, so this would be a hard change for me to test. Are you able to attempt this change and submit a PR? |
|
I'll take a look and see if I could debug this - and maybe provide a fix. Any tips are welcome as I don't have the full overview after the stuff was refactored. |
|
Any kind of update on this? I would love the trend arrows to be back for elite users. (Still not working on latest dev build). Would like to help but don't know where to begin (very new to coding). |
* PumpManager protocol changes for syncing * Remove debug prints
* LOOP-3830 PumpManager sync updates (#456) (#457) * PumpManager protocol changes for syncing * Remove debug prints * LOOP-3856: Adds canceling of temp basal if user lowers max basal below temp basal (#460) * ckpt * LOOP-3856: Wire up an "EnactTempBasal" hook for TherapySettings to use * PR Feedback: moved temp basal validation to LoopDataManager * Adds unit tests to LoopDataManager for canceling temp basal * Adds unit tests to LoopDataManager for checking loop is called when changing max basal * fix tests * Fix race condition causing intermittent unit test failures * Sigh...looks like we were "waiting" on the wrong queue * fix tests * PR Feedback * rename validateTempBasal -> validateMaxTempBasal to make it more clear * Fix comment * Rename ValidateMaxTempBasal -> MaxTempBasalSavePreflight * Remove "indirection" in syncBasalRateSchedule and maxTempBasalSavePreflight * Refactor stuff into new TherapySettingsViewModelDelegate The number of function aliases in `TherapySettingsViewModel` was getting to be a mess. I consolidated `SaveCompletion`, `MaxTempBasalSavePreflight`, `SyncBasalRateSchedule`, and `SyncDeliveryLimits` all into a new `TherapySettingsViewModelDelegate`. Things got a bit cleaner, and now `DeviceDataManager` handles doing both the `maxTempBasalSavePreflight` and `syncDeliveryLimits` so it is not so loose of a contract. * PR Feedback Co-authored-by: Pete Schwamb <[email protected]>
Looks like the trend arrow is missing from the BG value in the header on the newer builds. I think it's v1.3.x+
The text was updated successfully, but these errors were encountered: