Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow using non-string values for action.type #194

Closed
wants to merge 1 commit into from

Conversation

appmux
Copy link

@appmux appmux commented Dec 8, 2016

Allow using non-string values for action.type, i.e. Symbol('RANDOM_ACTION_TYPE').

Allow using non-string values for action.type, i.e. Symbol('RANDOM_ACTION_TYPE').
@codecov-io
Copy link

Current coverage is 8.80% (diff: 0.00%)

Merging #194 into master will not change coverage

@@            master      #194   diff @@
========================================
  Files            5         5          
  Lines          125       125          
  Methods          0         0          
  Messages         0         0          
  Branches         0         0          
========================================
  Hits            11        11          
  Misses         114       114          
  Partials         0         0          

Powered by Codecov. Last update 841af42...8fc9f83

@grushetsky
Copy link
Collaborator

grushetsky commented Dec 9, 2016

@appmux, you can use Symbol as action type by defining an action transformer.

@imevro imevro closed this Dec 9, 2016
@appmux
Copy link
Author

appmux commented Dec 9, 2016

Yup, I see that. But this kind of stuff should work out of the box in order to NOT BREAK an app if that particular transformer not applied.

Right now, if one uses Symbol() as an action type, redux-logger breaks the app which immediately discourage one from using the logger. Please consider adding this basic fix to the native code.

I mean, think about this:
console.log(Symbol()) - works no problem, I do not have to convert it to a string myself or use any sort of recipe.

@imevro
Copy link
Collaborator

imevro commented Dec 9, 2016

You have a point. I'll discuss it with @grushetsky

@appmux
Copy link
Author

appmux commented Dec 10, 2016

Спасибо!

@appmux
Copy link
Author

appmux commented Dec 12, 2016

Created an issue for visibility: https://github.com/evgenyrodionov/redux-logger/issues/195

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants