Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure release tags are cronological #18

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

ReenigneArcher
Copy link
Member

@ReenigneArcher ReenigneArcher commented Oct 26, 2023

Description

  • Use hhmmss as build number instead of commit hash
  • Remove padding from months and days

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

@ReenigneArcher
Copy link
Member Author

Alternative to this, use hhmmss as build number and remove commit7 hash entirely.

@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Merging #18 (ffddfdd) into master (c3791c6) will increase coverage by 0.17%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #18      +/-   ##
==========================================
+ Coverage   94.23%   94.40%   +0.17%     
==========================================
  Files           1        1              
  Lines         156      161       +5     
==========================================
+ Hits          147      152       +5     
  Misses          9        9              
Files Coverage Δ
action/main.py 94.40% <100.00%> (+0.17%) ⬆️

@ReenigneArcher ReenigneArcher force-pushed the fix-ensure-release-tags-are-cronological branch 4 times, most recently from 06bd865 to 11ba2de Compare October 26, 2023 00:44
@ReenigneArcher ReenigneArcher marked this pull request as ready for review October 26, 2023 00:45
@ReenigneArcher ReenigneArcher force-pushed the fix-ensure-release-tags-are-cronological branch from 11ba2de to 7bfe1d3 Compare October 26, 2023 01:48
@ReenigneArcher ReenigneArcher force-pushed the fix-ensure-release-tags-are-cronological branch from 7bfe1d3 to ffddfdd Compare October 26, 2023 01:50
@ReenigneArcher ReenigneArcher merged commit 2c5174f into master Oct 26, 2023
@ReenigneArcher ReenigneArcher deleted the fix-ensure-release-tags-are-cronological branch October 26, 2023 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant