Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement RetryScheduler utility #59

Merged
merged 5 commits into from
Jul 16, 2024

Conversation

FrogTheFrog
Copy link
Collaborator

Description

Added utility for... you guessed it! Retrying stuff until it succeeds! (to be used in Sunshine)

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

Copy link

codecov bot commented Jul 16, 2024

Codecov Report

Attention: Patch coverage is 96.10390% with 3 lines in your changes missing coverage. Please review.

Project coverage is 93.64%. Comparing base (51b7430) to head (9235be4).

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #59      +/-   ##
==========================================
+ Coverage   93.54%   93.64%   +0.10%     
==========================================
  Files          34       36       +2     
  Lines        1734     1811      +77     
  Branches      973     1014      +41     
==========================================
+ Hits         1622     1696      +74     
- Misses         54       61       +7     
+ Partials       58       54       -4     
Flag Coverage Δ
Linux 90.26% <95.83%> (+2.05%) ⬆️
Windows 93.60% <95.77%> (+0.09%) ⬆️
macOS 64.43% <63.51%> (-0.33%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/common/retryscheduler.cpp 100.00% <100.00%> (ø)
src/common/include/displaydevice/retryscheduler.h 95.58% <95.58%> (ø)

... and 1 file with indirect coverage changes

@FrogTheFrog
Copy link
Collaborator Author

I'm fine with the coverage, only 3 BS lines remaining...

@ReenigneArcher ReenigneArcher merged commit ae57fdf into LizardByte:master Jul 16, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants