Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add workaround for HDR high-contrast color bug #57

Merged
merged 4 commits into from
Jul 13, 2024

Conversation

FrogTheFrog
Copy link
Collaborator

Description

Add workaround for HDR high-contrast color bug. This made reverting settings more complicated as I had to explicitly track the state whether we were going to modify any settings.

State tracking is required as the HDR blank thingy can make the actual monitors "blink", which is fine if actual changes are being done, but annoying if no changes were made and monitors are still "blinking" with every method call...

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

Copy link

codecov bot commented Jul 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.54%. Comparing base (704295f) to head (f556175).

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #57      +/-   ##
==========================================
+ Coverage   93.26%   93.54%   +0.27%     
==========================================
  Files          34       34              
  Lines        1678     1734      +56     
  Branches      941      973      +32     
==========================================
+ Hits         1565     1622      +57     
+ Misses         61       52       -9     
- Partials       52       60       +8     
Flag Coverage Δ
Linux 88.20% <ø> (ø)
Windows 93.51% <100.00%> (+0.27%) ⬆️
macOS 64.76% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/windows/settingsmanagerapply.cpp 99.03% <100.00%> (+0.05%) ⬆️
src/windows/settingsmanagerrevert.cpp 98.95% <100.00%> (+1.48%) ⬆️
src/windows/settingsutils.cpp 96.48% <100.00%> (+0.57%) ⬆️

... and 1 file with indirect coverage changes

@ReenigneArcher ReenigneArcher merged commit e1281ca into LizardByte:master Jul 13, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants