Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): fix compat. issues with older compilers #140

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

FrogTheFrog
Copy link
Collaborator

Description

fix compat. issues with older compilers

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Copy link

sonarqubecloud bot commented Feb 4, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
8 New issues
D Maintainability Rating on New Code (required ≥ A)
8 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Copy link

codecov bot commented Feb 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.20%. Comparing base (41914d0) to head (cdb9d3c).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #140   +/-   ##
=======================================
  Coverage   93.20%   93.20%           
=======================================
  Files          34       34           
  Lines        2118     2118           
  Branches     1085     1085           
=======================================
  Hits         1974     1974           
+ Misses         82       75    -7     
- Partials       62       69    +7     
Flag Coverage Δ
Linux 93.65% <100.00%> (ø)
Windows 92.97% <100.00%> (ø)
macOS 74.09% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/common/types.cpp 98.63% <100.00%> (ø)
src/windows/win_api_layer.cpp 74.44% <100.00%> (ø)

... and 1 file with indirect coverage changes

@ReenigneArcher ReenigneArcher merged commit 7c44c02 into LizardByte:master Feb 4, 2025
21 of 22 checks passed
@FrogTheFrog FrogTheFrog deleted the linux-issues branch February 4, 2025 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants