Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nvenc): allow opt-out of filler data for AV1 #372

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

cgutman
Copy link
Contributor

@cgutman cgutman commented Oct 28, 2024

Description

This adds a patch to allow us to opt-out of AV1 padding OBUs for CBR with NVENC. Bitstream padding is a waste of valuable network bandwidth and also causes problems with Qualcomm's (broken) AV1 decoder.

Screenshot

Issues Fixed or Closed

Reference: LizardByte/Sunshine#3331

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

@cgutman cgutman merged commit 700fd1c into LizardByte:master Oct 29, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant