Skip to content

fix(mdns): don't hardcode mDNS instance name

Codecov / codecov/project succeeded Aug 25, 2024 in 0s

9.62% (+0.01%) compared to c9f853d

View this Pull Request on Codecov

9.62% (+0.01%) compared to c9f853d

Details

Codecov Report

Attention: Patch coverage is 33.33333% with 10 lines in your changes missing coverage. Please review.

Project coverage is 9.62%. Comparing base (c9f853d) to head (ca5036c).
Report is 1 commits behind head on master.

Files Patch % Lines
src/network.cpp 41.66% 1 Missing and 6 partials ⚠️
src/platform/linux/publish.cpp 0.00% 2 Missing ⚠️
src/platform/windows/publish.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           master   #3084      +/-   ##
=========================================
+ Coverage    9.61%   9.62%   +0.01%     
=========================================
  Files         101     101              
  Lines       17914   17934      +20     
  Branches     8371    8383      +12     
=========================================
+ Hits         1722    1727       +5     
- Misses      13321   13326       +5     
- Partials     2871    2881      +10     
Files Coverage Δ
src/network.h 0.00% <ø> (ø)
src/platform/macos/publish.cpp 5.12% <ø> (-2.57%) ⬇️
src/platform/windows/publish.cpp 0.00% <0.00%> (ø)
src/platform/linux/publish.cpp 0.00% <0.00%> (ø)
src/network.cpp 18.42% <41.66%> (+2.73%) ⬆️

... and 4 files with indirect coverage changes