Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docker: updates to docker images #942

Merged
merged 5 commits into from
Feb 20, 2023
Merged

docker: updates to docker images #942

merged 5 commits into from
Feb 20, 2023

Conversation

ReenigneArcher
Copy link
Member

@ReenigneArcher ReenigneArcher commented Feb 16, 2023 •
edited
Loading

Description

  • use --link argument for COPY directives
  • add custom directive to exclude specified stages from build cache
  • remove provenance.json file from upload artifacts
  • archlinux: remove publishing to AUR
  • docker: remove wip ubuntu-18.04 image

todo:

  • remove todo comment from archlinux docker file
  • update .github repo with changes to ci-docker.yml

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

@ReenigneArcher ReenigneArcher force-pushed the docker-fixes-and-enhancements branch 5 times, most recently from 7b28104 to 84c6e99 Compare February 18, 2023 18:37
@ReenigneArcher ReenigneArcher dismissed a stale review via 80fbcf6 February 18, 2023 18:53
@ReenigneArcher ReenigneArcher force-pushed the docker-fixes-and-enhancements branch 8 times, most recently from e9f96f2 to b2546e4 Compare February 18, 2023 21:19
@ReenigneArcher
docker: fixes and enhancements
86145db 
- use `--link` argument for COPY directives
- add custom directive to exclude specified stages from build cache
- remove `provenance.json` file from upload artifacts
- archlinux: fix `~/.ssh/config` file
- archlinux: fix secrets
@ReenigneArcher ReenigneArcher force-pushed the docker-fixes-and-enhancements branch from b2546e4 to 86145db Compare February 18, 2023 21:37
@ReenigneArcher ReenigneArcher force-pushed the docker-fixes-and-enhancements branch 8 times, most recently from 84fbe82 to c9797f8 Compare February 20, 2023 17:52
@ReenigneArcher ReenigneArcher force-pushed the docker-fixes-and-enhancements branch from c9797f8 to 1c92161 Compare February 20, 2023 18:20
@ReenigneArcher ReenigneArcher force-pushed the docker-fixes-and-enhancements branch from 1db1104 to 04957dc Compare February 20, 2023 18:56
@ReenigneArcher ReenigneArcher marked this pull request as ready for review February 20, 2023 19:03
@ReenigneArcher ReenigneArcher changed the title docker: fixes and enhancements docker: updates to docker images Feb 20, 2023
@ReenigneArcher ReenigneArcher merged commit 77deff1 into nightly Feb 20, 2023
@ReenigneArcher ReenigneArcher deleted the docker-fixes-and-enhancements branch February 20, 2023 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ReenigneArcher